fix: validate if value is dict before recursion in _filter_to_supported_schema#2477
Open
dechantoine wants to merge 1 commit into
Open
fix: validate if value is dict before recursion in _filter_to_supported_schema#2477dechantoine wants to merge 1 commit into
dechantoine wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This is a fix for #2476.
What changed: Added an isinstance(field_value, dict) guard in _filter_to_supported_schema before recursing into schema_field_names entries (specifically additionalProperties).
Why it crashed: The https://json-schema.org/understanding-json-schema/reference/object#additionalproperties allows additionalProperties to be either a boolean or a schema object. FastMCP (and other MCP SDKs) emit "additionalProperties": false by default, which triggered an AttributeError: 'bool' object has no attribute 'items'.
Testing: Verified against the repro script in the linked issue — old behavior is preserved for dict values, booleans now pass through correctly.
Happy to adjust if needed!
Antoine