Conversation
When there's no cached token and no way to get one (no refresh token, no private key, no grant type configured), hasAccess() returned false without touching lastError_, so getLastError() returned either undefined or a stale error from a previous, unrelated failure -- misleading whoever calls getLastError() to explain the false return to a user (see googleworkspace#543). Set lastError_ to a message describing the actual situation (redirect to getAuthorizationUrl(), or configure setPrivateKey()/setGrantType()) before returning false. Regenerated dist/OAuth2.gs via `npm run dist` (gulp) to keep it in sync with the src/ change, following the same pattern as googleworkspace#513. Verified against the existing mocha suite (59 passing before, 60 after) plus a new test covering this exact branch, asserting getLastError() now returns a message matching the new explanation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Reviewed-by: si-kui-a
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #543.
When there's no cached token and no way to get one (no refresh token, no private key, no grant type),
hasAccess()returnedfalsewithout touchinglastError_, sogetLastError()returned eitherundefinedor a stale error from a previous unrelated failure.Set
lastError_to a message describing the actual situation before returningfalse.Regenerated
dist/OAuth2.gsvianpm run dist(gulp) to keep it in sync with thesrc/change, following the same pattern as #513.Test plan
getLastError()now returns a message matching the new explanation.Co-authored with Claude Code (Anthropic); reviewed by @si-kui-a before submission.