fix(view): locked-repo reorder skips invisible repos#73
Closed
wgordon17 wants to merge 4 commits into
Closed
Conversation
Add optional visibleRepoNames parameter to moveLockedRepo. When provided, scans in the given direction to find the next visible locked repo and repositions the source adjacent to it. Falls back to adjacent swap when the parameter is omitted (backward compatible).
Add visibleLockedRepos prop to RepoLockControls. isFirst/isLast are now computed from the visible subset, so buttons correctly disable when hidden repos are at the boundary. Each tab derives visibleLockedRepos from its repoGroups memo intersected with viewState.lockedRepos.
Separates splice-shift correction from direction intent in insertIdx computation. Moves Set construction from click handler into createMemo so it derives once per prop change instead of per click.
Adds symmetric test coverage for skipping multiple invisible repos when moving down, complementing the existing up-direction test.
Member
Author
|
Superseded by #74 — locked repos are now always visible (de-emphasized when empty) instead of skip-invisible reordering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71