Skip to content

Allow 1 ULP on canvas import tests as noted in the comment. #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwyrzykowski merged 1 commit into from
Sep 1, 2026
Merged

Allow 1 ULP on canvas import tests as noted in the comment. #4697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/webgpu/util/texture/color_space_conversions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,13 @@ g.test('util_matches_2d_canvas')
{ x: 0, y: 0, z: 0 },
{ width, height, depthOrArrayLayers: 1 },
{ actTexelView, expTexelView },
{ maxDiffULPsForNormFormat: 0 }
// The canvas 2D side of this comparison is produced by the implementation's color
// management system, which typically quantizes to 8 bits internally, so its result
// may differ from this file's double-precision reference math by one unit in the
// last place. Several of the reference values here land within 0.05/255 of a
// round-to-nearest boundary (e.g. display-p3 (0x80, 0, 0x80) converts to an exact
// sRGB blue of 132.551/255), so requiring bit-exact agreement is not meaningful.
{ maxDiffULPsForNormFormat: 1 }
);

if (failedPixelsMessage !== undefined) {
Expand Down
Loading