feat (is-compatible): use plugin's min Grafana version as compatibility baseline#281
Draft
Ukochka wants to merge 1 commit into
Draft
feat (is-compatible): use plugin's min Grafana version as compatibility baseline#281Ukochka wants to merge 1 commit into
Ukochka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is-compatibleaction now reads the plugin's declared minimum Grafana version fromplugin.json(dependencies.grafanaDependency) and passes it to levitate via--min-package-version. Levitate then uses it as the baseline for the compatibility check.plugin.jsonor nografanaDependency, the argument is omitted and behavior is unchanged.--min-package-versionflag from levitate (feat: add min grafana version to compatibility check levitate#1044), which must be released first.