feat(backendbinary): require a linux/amd64 backend binary#642
Merged
Conversation
academo
commented
Jul 14, 2026
| // no executable in plugin.json skipping other checks | ||
| if data.Executable == "" { | ||
| return nil, nil | ||
| continue |
Collaborator
Author
There was a problem hiding this comment.
fixes a bug, we were potentially skipping nested backend binaries.
academo
marked this pull request as ready for review
July 14, 2026 12:21
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
tolzhabayev
approved these changes
Jul 14, 2026
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin declares a backend and matching binaries are present, the backendbinary pass now requires at least one to target linux/amd64. Platform is read from the embedded Go build info (GOOS/GOARCH), the same approach govulncheck uses, so it works on stripped production builds and does not trust file names.
backend-binary-not-linux-amd64rule (error) when no linux/amd64 binary is foundAlso fixes a pre-existing map-order bug where a frontend plugin.json with no executable could abort the whole pass and skip validating a nested backend.