fix: storefront category/brand/collection page crashes when PageSizeOptions is empty - #800
Merged
KrzysztofPajak merged 1 commit intoAug 28, 2026
Conversation
GetViewSortSizeOptionsHandler.PrepareSortingOptions() threw ArgumentNullException whenever the entity's PageSizeOptions field was left empty in admin (Category/Brand/Collection/Vendor/ProductTag all share this handler), crashing the storefront page before rendering. The guard was misplaced: PrepareSortingOptions never reads PageSizeOptions at all. The actual consumer, PreparePageSizeOptions, already null-checks it correctly and falls back to the default page size when null or empty. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QArzgnTu2jhTmm4LiMjuNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArgumentNullExceptionthrown on the storefront whenever a Category/Brand/Collection/Vendor/ProductTag's admin Page size options field is left empty.GetViewSortSizeOptionsHandler.PrepareSortingOptions()had a strayArgumentNullException.ThrowIfNull(request.PageSizeOptions)guard, even though that method never readsPageSizeOptions. The actual consumer,PreparePageSizeOptions(), already handlesnull/empty correctly and falls back to the entity's default page size.Change
GetViewSortSizeOptionsHandler.PrepareSortingOptions.Testing
dotnet build src/Web/Grand.Web/Grand.Web.csproj— succeeded, 0 errors.🤖 Generated with Claude Code