Repository navigation
fix: end stale agreements through the cancelling status - #729
Merged
MoonBoi9001 merged 6 commits intoOct 5, 2026
Conversation
The check for indexers that stopped serving cancelled first and marked afterwards, missing the read before sending, the retry limit and the alert. It now marks the agreement cancelling, noted as abandoned so it still ends that way, and the code that only it used is gone.
…/abandon-stale-agreements-through-cancelling
MoonBoi9001
added this pull request to stack #731
October 5, 2026 10:03
Several comments still said a cancelled agreement always ends cancelled by dipper and that the liveness check cancels directly. They now say an agreement dipper ends because its indexer stopped serving it passes through cancelling and ends abandoned by the indexer.
The alert for a cancel that keeps failing didn't say whether dipper was ending the agreement because its indexer stopped serving it, which an operator needs to decide what to do. It now carries that.
MoonBoi9001
marked this pull request as ready for review
October 5, 2026 10:45
…/abandon-stale-agreements-through-cancelling
A stale agreement with no stored terms hash was marked cancelling and replaced, but its cancel can never be sent, so both indexers would be paid. It is left active with an ERROR for an operator, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The liveness checker, which ends agreements whose indexer stopped serving them, now marks each one cancelling before anything is sent, like every other cancel, so it gets the read before sending, the retry limit and the stuck alert. A new
abandonedcolumn keeps such an agreement ending as abandoned by the indexer rather than cancelled by dipper, and the abandon code nothing else used is removed.