Repository navigation
fix: record reopened accepts and quiet expected races - #730
Merged
Conversation
When the listener found an agreement dipper had cancelled live after all and moved it back to cancelling, it then checked the old status and skipped recording the accept, so the cancel retry treated a paying agreement as an unaccepted offer. The accept is now recorded.
An agreement that ended, or started cancelling, between being listed and being marked was logged as a failure, with an ERROR and a failure count in reassessment. That race is expected and needs nothing more, so it is now logged at debug level and not counted.
A list of queued cancels that was never filled made its assertion always pass, and a way to mark an agreement already cancelled on-chain was never read, so tests using it passed for another reason. Both are gone, along with a comment naming code that no longer exists.
…b9/record-reopened-accepts-and-quiet-expected-races
MoonBoi9001
added this pull request to stack #731
October 5, 2026 10:03
…b9/record-reopened-accepts-and-quiet-expected-races
The comment ended with "True if it was" straight after "unless the chain shows it already ended", which read as the opposite of what it returns.
MoonBoi9001
marked this pull request as ready for review
October 5, 2026 10:45
…b9/record-reopened-accepts-and-quiet-expected-races
MoonBoi9001
deleted the
mb9/record-reopened-accepts-and-quiet-expected-races
branch
October 5, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the chain listener moves an agreement dipper had cancelled back to cancelling because it is live after all, it now also records the accept, so the cancel retry treats it as paying. An agreement that ends between being listed and being marked is now logged at debug level and no longer counted as a failure, and test helpers that nothing read or wrote are removed.