Repository navigation
fix: keep a reopened agreement's end record accurate - #732
Merged
MoonBoi9001 merged 3 commits intoOct 6, 2026
Merged
Conversation
An agreement reopened because the chain shows it live kept its earlier end on record, such as a withdrawn offer, so its later real end was announced with the old transaction and time, or never if one had gone out. That record is now cleared when the chain showed it live.
If the chain listener marked an agreement ended between dipper sending its cancel and confirming it, the confirm found nothing to update, warned that it failed, and reported the agreement as still cancelling. It now counts it as ended and logs that at debug level.
A reopen after a failed chain read keeps the end on record, and later cancels only filled blank fields, so a withdrawn offer's end could still be announced for an agreement accepted after it. An end recorded before the accept can't be the real one, so a later end now replaces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agreement found live again after dipper recorded it ended, such as an offer withdrawn then accepted when it landed anyway, now has its real end announced with the right transaction and time: the reopen clears the stale record when the chain showed it live, and any end recorded before the accept gives way to a later one. An agreement the chain listener marks ended just before dipper confirms its own cancel now counts as ended, not a failure.