Repository navigation
refactor: announce agreements however old they are - #734
Merged
MoonBoi9001 merged 3 commits intoOct 8, 2026
Merged
Conversation
Dipper skipped announcing the accept and end of agreements created before its first release with lifecycle events, but that only spared consumers late events for old testnet agreements. Every agreement is now announced when the chain shows it accepted or ended.
When the listener recorded an agreement's accept and end from the chain, it recorded the end before the accept, so an older end from before the accept, such as its offer's withdrawal, was kept. The end is now recorded again after the accept, so the real one replaces it.
A comment on the accepted-event sweep said agreements from before events existed are never announced, which stopped being true once the date that skipped them was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dipper no longer skips announcing agreements created before 2026-08-11, the release that first sent lifecycle events: that date only spared consumers late events for old testnet agreements. Every agreement is now announced when the chain shows it accepted or ended.