fix: set gas price explicitly when submitting votes - #44
Merged
Merged
Conversation
suntzu93
force-pushed
the
fix/explicit-gas-price
branch
from
September 25, 2026 22:29
0c06420 to
a51b1e9
Compare
Maikol
approved these changes
Sep 29, 2026
Both deny_many implementations submitted votes without setting any fee field, so ethers filled in the EIP-1559 values using eip1559_default_estimator. That estimator returns a flat EIP1559_FEE_ESTIMATION_DEFAULT_PRIORITY_FEE of 3 gwei whenever the base fee is below 100 gwei, which on Arbitrum is always the case - the base fee there is around 0.02 gwei. This was harmless while Arbitrum discarded priority fees. Since 2026-09-23 the tip is actually charged, and the effective gas price on oracle votes went from 0.0200 to 3.0200 gwei, a 151x increase. Set the gas price explicitly, the way data_edge.rs already does, so the effective price stays at the base fee.
Maikol
force-pushed
the
fix/explicit-gas-price
branch
from
September 29, 2026 21:01
a51b1e9 to
b781b1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
deny_manyimplementations inavailability-oracle/src/contract.rssubmitted votes without setting any fee field:With no fee fields set, ethers fills in the EIP-1559 values using
eip1559_default_estimator. That estimator does not consult the chain when the base fee is low — it returns a flat constant:It uses that constant verbatim whenever the base fee is below
EIP1559_FEE_ESTIMATION_PRIORITY_FEE_TRIGGER(100 gwei). On Arbitrum the base fee is ~0.02 gwei, so this branch is taken every time and every vote offers a 3 gwei tip.That was harmless while Arbitrum discarded priority fees. Since 2026-09-23 the tip is actually charged, and the effective gas price on oracle votes jumped from 0.0200 to 3.0200 gwei — a 151x increase. Measured on the mainnet oracle (index 4): cost per vote went from ~$0.0014 to ~$0.28, and a single
voteManyreached $7.98.data_edge.rswas never affected, because it already sets its gas price explicitly.Fix
Set the gas price explicitly at both vote call sites, mirroring
data_edge.rs, so ethers never reaches for its default estimator. The 20% buffer matches whatdata_edge.rsuses.Verification
cargo checkclean. Deployed to the mainnet oracle and confirmed on chain:The transaction still goes out as EIP-1559, but with the priority fee set to the buffered base fee rather than the estimator's 3 gwei.