Repository navigation
Mark trybuild as used in juniper_codegen_tests on non-stable toolchains - #1414
Merged
Merged
Conversation
…chains ## Why `test_failing_compilation()` exists only on the stable toolchain. On beta and nightly, nothing in the crate used `trybuild`, so `cargo clippy --tests` failed with the `unused_crate_dependencies` lint. ## What changed The `for_codegen_tests_only` module imports `trybuild` on non-stable toolchains. ## Testing `cargo clippy --workspace --all-features --tests -- -D warnings` passes on stable and nightly. The codegen tests still run on stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo clippy --workspace --all-features --tests -- -D warningsfailed on beta and nightly with theunused_crate_dependencieslint. Onlytest_failing_compilation()usestrybuild, and the test exists only on the stable toolchain. CI runs Clippy only on stable, so CI did not catch the error.The
for_codegen_tests_onlymodule ofjuniper_codegen_testsnow importstrybuildon the other toolchains. The codegen tests still run on stable.