refactor(git): model refs as domain types instead of strings - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the string-and-flag ref representation with a tagged union:
RefName wraps a ref's short name, Branch encodes local vs remote as
variants rather than a separate kind field, and Ref composes the two
so a badge's local/remote/tag identity lives in exactly one place.
RefKind and RefBadge are gone.
Move refs-pane flattening out of the Git layer:
RepoRefs::rowsandRefRow become
app::state::ref_pane_rowsandRefPaneRow, since the"Local Branches / Remote Branches / Tags" sections are presentation,
not domain. RepoRefs now carries one ordered branches vec instead of
separate local and remote lists.
No behavior change: the same refs are discovered, named, ordered and
rendered as before.