Use relative URLs to support subpath deployments - #17
Open
fjl5 wants to merge 1 commit into
Open
Conversation
- Add <base href="/"> in index.html as the anchor relative paths resolve against - Set homepage to "." - Replace window.location-based URL construction in api.ts/config.ts with relative paths - Replace manual window.location.pathname parsing with useLocation()/ useParams(), avoiding a doubled subpath prefix - Modify SPA fallback in conf/web.conf to resolve relative to the location block - When serving or embedding under a subpath, only <base href> needs to be adjusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<base href="/">in index.html as the anchor relative paths resolve against"."window.location-based URL construction inapi.ts/config.tswith relative pathswindow.location.pathnameparsing withuseLocation()/useParams(), avoiding a doubled subpath prefixconf/web.confto resolve relative to the location blockWith these changes, when serving or embedding under a subpath, only
<base href>needs to be adjusted