fix(release): publish plugin config image - #15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37fd6e486a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| test "$(find /src/velocity/build/libs -maxdepth 1 -type f -name '*.jar' | wc -l)" -eq 1 && \ | ||
| cp "$(find /src/velocity/build/libs -maxdepth 1 -type f -name '*.jar' -print -quit)" /out/plugin.jar | ||
|
|
||
| FROM alpine:3 |
There was a problem hiding this comment.
The final stage inherits Alpine's default CMD ["/bin/sh"]; omitting a new CMD instruction does not clear the base image configuration. Consequently, the published image does have a command despite the data-only image contract and the comment below, while the contract test only scans this Dockerfile for explicit instructions and cannot detect the inherited command. Use a commandless base such as scratch or explicitly clear the inherited command.
Useful? React with 👍 / 👎.
| val version = strictVersion(root.resolve("version.txt").readText()) | ||
|
|
||
| assertEquals(version, System.getProperty("releaseVersion")) |
There was a problem hiding this comment.
When check is run with a valid -PversionOverride different from version.txt, Gradle correctly sets releaseVersion to the override, but this test always derives its expected value from the file and therefore fails. The shaded-artifact test has the same unconditional file expectation, so the override path promised by the build configuration cannot be validated and any pipeline running checks with an override will reject a valid build.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Follow-up
After CI and review, merge this PR. Release Please must create the patch release; no manual tag. The released image will then be pinned before plugin-resourcepacks in Bundle and Stage.