Skip to content

fix: recover config defaults after degraded bootstrap - #17

Merged
lusu007 merged 1 commit into
mainfrom
codex/plugin-config-degraded-bootstrap-retry
Aug 21, 2026
Merged

lusu007 merged 1 commit into
mainfrom
codex/plugin-config-degraded-bootstrap-retry

Conversation

@lusu007

@lusu007 lusu007 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Retries the default-config seed only for scopes whose initial degraded bootstrap could not reach service-config. Once the service recovers, the next config refresh or NATS event seeds the missing defaults and loads the snapshot.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • ♻️ Refactoring
  • 📚 Documentation
  • 🔧 Chore

Related Issues

  • Fixes #

Testing

  • Unit tests pass (./gradlew check)
  • Manual testing completed (Dev Bundle exposed the delayed service-config rollout)
  • New tests added for new functionality

Checklist

  • I have performed a self-review of my own code
  • Tests have been added/updated and pass (if needed)
  • Documentation has been updated (if needed; not required)

@lusu007
lusu007 merged commit 210a881 into main Aug 21, 2026
2 checks passed
@lusu007
lusu007 deleted the codex/plugin-config-degraded-bootstrap-retry branch August 21, 2026 14:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8784faa6d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

scope: AppEnvScope,
) {
val defaults =
scope.bindingsSnapshot().values.filterNot(ConfigBinding<*>::initialized).map { binding

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retry defaults even when the cache initialized the binding

When the initial default sync fails but degraded bootstrap successfully restores this binding from a cached snapshot, initialized() is true, so this filter produces no defaults. refreshScope then removes the scope's pending-default marker, meaning subsequent refreshes never retry the failed seed even after service-config recovers. Track and retry the bindings whose default sync failed rather than deriving that set from runtime initialization state.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant