proto-loader: Update protobufjs dependency to 8.x - #3067
Conversation
Instead of keeping internal "declare module" override, use the upstream version added in protobufjs/protobuf.js#2232 and released in v8.2.0.
As per the note in grpc#3062 (comment)
|
Since v8 has vastly improved typings that CC: @dcodeIO |
`windows-latest` defaults to `windows-2025` since September 2025[^1] and ships CMake v4. This project still has requirements for specific v3 CMake. [^1]:https://github.blog/changelog/2025-07-31-github-actions-new-apis-and-windows-latest-migration-notice/
|
@murgatroid99 I've pushed one extra commit for the Windows build - seems like it's just due to the runner image update. This should confirm that. |
|
One argument for this that hasn't been made on either this PR or #3062: the 8.x train also removes
Measured with a clean The
It was resolved upstream in 8.4.0, but every package still on I ran into this from the other direction while auditing a dependency tree that had both so the ecosystem benefit only materialises once the remaining No action needed on my part — just adding the numbers in case they're useful for prioritising the review. Happy to test against a real tree if that helps. |
The only breaking change in the 8.x train is the Edition 2024 support
I took the liberty to bump the version number by a minor the same way 7b4704c did.
Fixes #3062