feat(config): Add YAML edit foundation module - #2004
Merged
Merged
Conversation
Introduces cli/config with a yaml_edit module that splices mapping entries into an existing YAML document via yamlpatch instead of round-tripping through a generic serializer, so comments and &anchor/<<: *anchor merge keys in clouds.yaml/secure.yaml survive an edit byte-for-byte. This is prep work for PR #1888's `osc config clouds add`, whose serde_yaml-based approach expands anchors and drops comments; the crate/module land separately so that PR's eventual rewire stays a small, attributable diff on top of this. yamlpatch/yamlpath require a newer Rust toolchain than the rest of the workspace, so cli/config pins its own rust-version rather than raising the workspace floor; nothing else depends on this crate, so SDK-only consumers are unaffected. CI's test job toolchain is bumped to match, since cli/* is in the default build set. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces cli/config with a yaml_edit module that splices mapping
entries into an existing YAML document via yamlpatch instead of
round-tripping through a generic serializer, so comments and
&anchor/<<: *anchor merge keys in clouds.yaml/secure.yaml survive an
edit byte-for-byte. This is prep work for PR #1888's
osc config clouds add, whose serde_yaml-based approach expands anchors anddrops comments; the crate/module land separately so that PR's
eventual rewire stays a small, attributable diff on top of this.
yamlpatch/yamlpath require a newer Rust toolchain than the rest of
the workspace, so cli/config pins its own rust-version rather than
raising the workspace floor; nothing else depends on this crate, so
SDK-only consumers are unaffected. CI's test job toolchain is bumped
to match, since cli/* is in the default build set.
Assisted-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com