Skip to content

fix(ble_gap): fix NULL deref and use-after-free in ble_gap_rx_rd_rem_ver_info_complete #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tahiraltundag wants to merge 1 commit into
base: release/2.5
Choose a base branch
from
Open

fix(ble_gap): fix NULL deref and use-after-free in ble_gap_rx_rd_rem_ver_info_complete #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/nimble/nimble/host/src/ble_gap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2853,23 +2853,25 @@ ble_gap_rx_rd_rem_ver_info_complete(const struct ble_hci_ev_rd_rem_ver_info_cmp
{
#if NIMBLE_BLE_CONNECT
struct ble_hs_conn *conn;
int is_master;

ble_hs_lock();

conn = ble_hs_conn_find(le16toh(ev->conn_handle));

ble_hs_unlock();
if (conn == NULL) {
ble_hs_unlock();
return;
}

conn->bhc_rd_rem_ver_params.version = ev->version;
conn->bhc_rd_rem_ver_params.manufacturer = ev->manufacturer;
conn->bhc_rd_rem_ver_params.subversion = ev->subversion;
is_master = conn->bhc_flags & BLE_HS_CONN_F_MASTER;
ble_hs_unlock();

if ((conn != NULL) && !(conn->bhc_flags & BLE_HS_CONN_F_MASTER)) {
if (!is_master) {
ble_gap_rd_rem_sup_feat_tx(ev->conn_handle);
} else {
if ((conn != NULL) && (ev->status == 0)) {
ble_gap_event_connect_call(ev->conn_handle, ev->status);
}
} else if (ev->status == 0) {
ble_gap_event_connect_call(ev->conn_handle, ev->status);
}
#endif
}
Expand Down
Loading