267 Book Search Autocomplete - #282
Draft
ajdeleon wants to merge 13 commits into
Draft
Conversation
* added to .gitignore * added a file testdb_seed * removed reseting db from docker_script because this is handled in docker-compose-dev NOTE: docker-compose.yml is not currently used and will not reset or seed the database. Just use docker-compose-dev.yml for now.
- make into functional component - use hooks for state management - fetch books for autocomplete component - replace regular input with autocomplete component
ajdeleon
requested review from
adamzev,
danielkhunter and
mexmanny
and removed request for
mexmanny
May 27, 2019 00:56
Collaborator
|
@ajdeleon quick update, the code looks good, going to pull this branch and run through it to see if I can spot any ux quirks. |
Collaborator
|
@ajdeleon heads up, looks like you'll need to merge master into this branch since you're using hooks. This branch is still using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status:
🚧 In development
🚫 Do not merge
Deploy link
Description
I'm looking for some general feedback on this.
Does this seem reasonable?
Will it scale/Do we need it to be super scalable?
Any issues you come across?
Related issues: #267
Todos