Skip to content

HCK-16096: add support of hybrid tables on PP and for FE logic #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VitaliiBedletskyi wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

HCK-16096: add support of hybrid tables on PP and for FE logic #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/configs/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = {
dropSchema: 'DROP SCHEMA IF EXISTS ${name};\n',

createTable:
'CREATE${orReplace}${temporary}${transient} TABLE${tableIfNotExists}\n' +
'CREATE${orReplace}${temporary}${transient}${hybrid} TABLE${tableIfNotExists}\n' +
'\t${name} (\n' +
'\t\t${column_definitions}' +
'${out_of_line_constraints}\n' +
Expand Down
3 changes: 3 additions & 0 deletions forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ module.exports = (baseProvider, options, app) => {

createTable(tableData, isActivated) {
const schemaName = get(tableData, 'schemaData.schemaName');
const hybrid = preSpace(tableData.hybrid && 'HYBRID');
const temporary = preSpace(tableData.temporary && 'TEMPORARY');
const transient = preSpace(tableData.transient && !tableData.temporary && 'TRANSIENT');
const orReplace = preSpace(tableData.orReplace && 'OR REPLACE');
Expand Down Expand Up @@ -469,6 +470,7 @@ module.exports = (baseProvider, options, app) => {

return assignTemplates(templates.createTable, {
name: tableData.fullName,
hybrid,
temporary,
transient,
tableIfNotExists,
Expand Down Expand Up @@ -840,6 +842,7 @@ module.exports = (baseProvider, options, app) => {
...tableData,
fullName,
name: tableName,
hybrid: firstTab.hybrid,
temporary: firstTab.temporary,
transient: firstTab.transient,
external: firstTab.external,
Expand Down
69 changes: 62 additions & 7 deletions properties_pane/entity_level/entityLevelConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ making sure that you maintain a proper JSON format.
}

*/

[
{
"lowerTab": "Details",
Expand Down Expand Up @@ -162,10 +161,16 @@ making sure that you maintain a proper JSON format.
"propertyType": "checkbox",
"dependency": {
"type": "not",
"values": {
"key": "external",
"value": true
}
"values": [
{
"key": "external",
"value": true
},
{
"key": "hybrid",
"value": true
}
]
}
},
{
Expand Down Expand Up @@ -201,6 +206,36 @@ making sure that you maintain a proper JSON format.
{
"key": "transient",
"value": true
},
{
"key": "hybrid",
"value": true
}
]
}
},
{
"propertyName": "Hybrid",
"propertyKeyword": "hybrid",
"propertyType": "checkbox",
"dependency": {
"type": "not",
"values": [
{
"key": "external",
"value": true
},
{
"key": "transient",
"value": true
},
{
"key": "dynamic",
"value": true
},
{
"key": "iceberg",
"value": true
}
]
}
Expand Down Expand Up @@ -584,6 +619,10 @@ making sure that you maintain a proper JSON format.
{
"key": "external",
"value": true
},
{
"key": "hybrid",
"value": true
}
]
}
Expand All @@ -602,6 +641,10 @@ making sure that you maintain a proper JSON format.
{
"key": "external",
"value": true
},
{
"key": "hybrid",
"value": true
}
]
}
Expand Down Expand Up @@ -644,6 +687,10 @@ making sure that you maintain a proper JSON format.
{
"key": "transient",
"value": true
},
{
"key": "hybrid",
"value": true
}
]
}
Expand Down Expand Up @@ -790,7 +837,11 @@ making sure that you maintain a proper JSON format.
"ESCAPE_UNENCLOSED_FIELD": "\\",
"TRIM_SPACE": false,
"FIELD_OPTIONALLY_ENCLOSED_BY": "NONE",
"NULL_IF": [{ "NULL_IF_item": "\\N" }],
"NULL_IF": [
{
"NULL_IF_item": "\\N"
}
],
"ERROR_ON_COLUMN_COUNT_MISMATCH": true,
"VALIDATE_UTF8": true,
"EMPTY_FIELD_AS_NULL": true,
Expand Down Expand Up @@ -1029,7 +1080,11 @@ making sure that you maintain a proper JSON format.
]
},
"defaultValue": {
"NULL_IF": [{ "NULL_IF_item": "\\N" }]
"NULL_IF": [
{
"NULL_IF_item": "\\N"
}
]
},
"structure": [
{
Expand Down
Loading