Fix repair loop for unresolved review threads#153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The ci-decision-plane loop left five PRs idle because unresolved inline review comments were invisible to forge-loop.
gh pr view --commentsdoes not include reviewThreads, while the repair context formatter already expected them.Tests
uv run --extra dev ruff check src/forge_loop/gh.py src/forge_loop/runner/tick.py src/forge_loop/worker.py tests/test_dispatch_axis_filter.py tests/test_gh_review_threads.pyuv run --extra dev pytest tests/test_gh_review_threads.py tests/test_dispatch_axis_filter.py tests/test_worker.py -qgit diff --checkFull
uv run --extra dev pytest -qcurrently has unrelated pre-existing isolation/config failures in CLI/runner tests; the targeted repair surface is green.