docs(manifesto): state-based rules need a state-based gate (feedback from cli.py bloat)#157
Merged
Merged
Conversation
CTO observation: src/forge_loop/cli.py is 1705 LOC. The Python soft-cap is 500. The critic never flagged it because cli.py grew 50-100 LOC per PR over many merges. Each individual increment was reasonable; the cumulative state-violation slipped past every per-PR review. Boiling-frog. Adds the rule: a manifesto rule checkable only by codebase state (file size, module count, deprecated-pattern count, test coverage, dead code) MUST register a probe in the codebase auditor (#156). Per-PR critic catches deltas; the auditor catches accumulation. Rule + gate ship together — otherwise the rule is decoration. References #155 (the cli.py split that this gap surfaced) and #156 (the auditor framework that closes the gap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boiling-frog observation by the CTO — cli.py is 1705 LOC, 3.4x soft-cap, critic never flagged because each PR-delta was reasonable. Adds the rule + cites #155 / #156.