[EAPQE-5470] Add support for MicroProfile LRA in the console#145
Open
hpehl wants to merge 1 commit into
Open
Conversation
kstekovi
reviewed
May 19, 2026
| before(function () { | ||
| cy.startWildflyContainer().then((result) => { | ||
| managementEndpoint = result as string; | ||
| cy.skipIf(cy.isEAP(managementEndpoint), this); |
Collaborator
There was a problem hiding this comment.
Could you clarify the intent of cy.skipIf(cy.isEAP(managementEndpoint), this) in both test files? MicroProfile LRA is an EAP XP feature, so ideally these tests should also run on EAP XP. If cy.isEAP() returns true for both base EAP and EAP XP, the tests would be skipped on all EAP variants and only run on WildFly upstream — is that intentional?
| before(function () { | ||
| cy.startWildflyContainer().then((result) => { | ||
| managementEndpoint = result as string; | ||
| cy.skipIf(cy.isEAP(managementEndpoint), this); |
Collaborator
There was a problem hiding this comment.
Same question as in the coordinator test — could you clarify the intent of cy.skipIf(cy.isEAP(managementEndpoint), this)? If cy.isEAP() returns true for EAP XP as well, these tests would never run on any EAP variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redhat.atlassian.net/browse/EAPQE-5470
https://redhat.atlassian.net/browse/EAP7-2051