ci: two specs existed in no tier — wire them (DEV-2203) - #242
Merged
Conversation
The sign-off audit found preview-scheme.spec.ts (DEV-2561's live proof) gated behind E2E_LIVE but absent from every e2e-live step list, and session-abandoned-create.spec.ts (DEV-2567's leak regression) skipping forever for want of an API base — the orphaned-gate anti-pattern TESTING.md names, recurring days after it was written down. The scheme spec joins the sandpack step; the leak spec joins the token-gated step (its /api/admin reads need auth on prod) with E2E_API_BASE wired.
Both sides appended a spec to the sandpack step's file list: preview-scheme.spec.ts (this branch, the orphan being wired) and preview-head-assets.spec.ts (master, DEV-2576). Kept both.
demtario
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the final sign-off sweep: two specs on master ran in no CI tier — the exact orphaned-gate anti-pattern
runner/docs/TESTING.mdcodifies ("every env gate needs a workflow home"), recurring days after it was written down.e2e/preview-scheme.spec.ts(DEV-2561's live proof that the shell's colour scheme reaches the grid) —E2E_LIVE-gated, named in no e2e-live step. → joins the nightly sandpack step.e2e/session-abandoned-create.spec.ts(DEV-2567's leak regression) — skips without an API worker, and nothing anywhere setE2E_API_BASE. Its/api/admin/sessionsreads are auth-gated on prod, so it joins the token-gated step (share round-trip), inheriting its trace-off/scrub secret hygiene. Runs wheneverE2E_BROKER_TOKENis fresh.Worth a thought later: the presence gate proves a test exists for a change, but nothing yet proves a gated spec is reachable by some workflow — this is the second time orphans slipped through. A guide-tracks-style pipeline test that diffs
e2e/*.spec.tsgates against the workflow step lists would close the class.Note
Cursor Bugbot is generating a summary for commit 4100b7e. Configure here.