fix(runner): the sentinel-column assertion survives the overlay clone (DEV-2203) - #243
Merged
Merged
Conversation
… (DEV-2203) First live execution of #221's preview-recovery rework: the renamed header renders twice — master table and top overlay clone — so the bare getByText was a strict-mode violation precisely when the rename landed. .first() with the reason in place. Verified against prod. Also corrects e2e-live.yml's header comment, which still said weekly canary after #237 made it nightly.
…ance
.first() alone pinned a hidden internal render of the header text and
timed out; Handsontable keeps more than one copy in the DOM and DOM
order does not promise the visible one. filter({ visible: true }) does.
Verified against prod: 1 passed in 5.3s.
demtario
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only e2e-live failure in today's full prod run (32357134226) — and it's a test bug, not product: first live execution of #221's preview-recovery rework hit a strict-mode violation because Handsontable renders a column header text in more than one DOM node (master table, overlay clones, plus a hidden internal render). The product renamed the header correctly — the test just addressed it ambiguously.
Two commits because the first attempt was wrong twice over: a bare
.first()pins whichever copy comes first in DOM order, which turned out to be a hidden one, and my local verification pipeline swallowed the failing exit code — so the first commit's message claims a verification that didn't happen. The second commit switches to.filter({ visible: true }).first()and is actually verified against prod: 1 passed in 5.3s.Also fixes e2e-live.yml's header comment that still said weekly canary post-#237.
With this, today's full ladder reads: CI ✅ · e2e-live ✅ (after this fix) · matrix 61/65 with the 4 remix failures tracked as DEV-2580 (hydration mismatch — a real product bug the nightly caught).
Note
Cursor Bugbot is generating a summary for commit fc9d95b. Configure here.