test(runner): pin the owner filter's case-folding at both seams (DEV-2519) - #254
Open
danielzytohoc wants to merge 1 commit into
Open
test(runner): pin the owner filter's case-folding at both seams (DEV-2519)#254danielzytohoc wants to merge 1 commit into
danielzytohoc wants to merge 1 commit into
Conversation
…2519) The DEV-2519 suites were green but two deliberate behaviors had no test that fails when they go away (docs/TESTING.md bar), both on the two-writer created_by casing split (DEV-2501): - ownerOptions folding two casings into one option: every unit fixture was lowercase, so keying options on the raw local part — same person twice, counts split — passed all 9 tests. Verified by that exact mutation: only the new test catches it. - the URL seed's toLowerCase in MyDemos (a pasted ?owner=SOMEONE.ELSE link): removing it kept every test green while the grid filtered under an "Everyone" label. The new e2e asserts the cards AND the picker label; against that mutation it fails on the label, for the right reason. Test-only change; both files run in the existing CI globs.
demtario
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening follow-up to the DEV-2519 owner filter (task). The feature's suites are green and cover every bullet in the ticket, but audited against
docs/TESTING.md("a test must fail when the control goes away"), two deliberate behaviors had no such test. Both sit on the two-writercreated_bycasing split (DEV-2501).Unit —
ownerOptionsfolds two casings into one owner. Every existing fixture is lowercase, so a refactor that keys options on the raw local part (same person listed twice, counts split) passed all 9 tests. Verified by applying exactly that mutation: only the new test catches it.E2E — a pasted
?owner=SOMEONE.ELSElink.filterByOwnernormalises its argument, so dropping the.toLowerCase()from the URL seed inMyDemos.tsxkeeps every test green while the grid filters under an "Everyone" label — a lying picker on the exact artefact the ticket calls shareable. The new spec asserts the cards and the label; against that mutation it fails on the label, for the right reason.Test-only change (+28 lines); both files already run in the CI globs (
pipeline/*.test.mjs, unfilteredplaywright test). Fresh local runs: unit 10/10,all-demos.spec.ts12/12.Note
Low Risk
Test-only additions; no production behavior or security-sensitive code is changed.
Overview
Adds two tests so the All Demos owner filter cannot silently drop case-folding around mixed
created_bycasings (browser vs MCP).A unit test asserts
ownerOptionsmerges two casings of the same address into one option with a combined count. An e2e spec loads?owner=SOMEONE.ELSEand checks both the filtered cards and that the picker still labels the person, not Everyone.Reviewed by Cursor Bugbot for commit a07a4d1. Bugbot is set up for automated code reviews on this repo. Configure here.