Repository navigation
fix: end the stream when replay fails instead of leaking - #9
Merged
Merged
Conversation
Marsup
approved these changes
Oct 7, 2026
An error status stops EventSource for good; an ended stream makes it retry and runs the normal cleanup. Null-character ids are rejected before they reach the replay buffer. Closes #8
damusix
force-pushed
the
fix/replay-failure-leak
branch
from
October 21, 2026 15:46
0275976 to
51bfed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If replay fails, the session now closes and the stream ends with a 200, and the error is reported through
request.log(). An error status would make EventSource stop reconnecting for good. An ended stream makes it reconnect afterretry, and the normal cleanup runs:onUnsubscribefires and themaxSessionsslot is freed.publish(),broadcast()and the built-in replayers'record()now reject event ids containing a null character, so a bad id can't get into the replay buffer.Closes #8