support pagination in clients, with unit test. basic fifo queue to avoid rate limiting - #1
Open
furiousOyster wants to merge 2 commits into
Open
support pagination in clients, with unit test. basic fifo queue to avoid rate limiting#1furiousOyster wants to merge 2 commits into
furiousOyster wants to merge 2 commits into
Conversation
added 2 commits
August 28, 2015 07:14
unit test added for pagination. default pagination set as explaining variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freshbooks limits api requests, so we can't just make them as fast as we would like.
http://www.freshbooks.com/developers
Request Limits
There are no limit on the number of API requests per day. However, requests will be rate-limited if too many calls are made within a short period of time. Additionally, a maximum of 100 results will be returned for list methods, regardless of the value sent with the per_page parameter.
On the phone, they said 15 completed requests per second.
Also we need pagination, if we have a large number of clients.