Keep track of indices in listParser errors - #1186
Merged
Merged
Conversation
Collaborator
Author
|
I wasn't sure whether changing error messages required bumping the major version number but there is already multiple precedent in aeson where that only bumps the minor version number. |
Collaborator
|
A small nitpick: This change doesn't make any tests fail, though there is a part test suite testing the error messages. I'd liked to see a test change and/or addition as well! |
Collaborator
Author
|
Good idea. I should make a PR template to remind myself to add tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1184