Skip to content

Show built keys by rule in ghcide-bench summary - #5055

Merged
crtschin merged 4 commits into
haskell:masterfrom
crtschin:crtschin/bench-rule-key-histogram
Aug 27, 2026
Merged

Show built keys by rule in ghcide-bench summary#5055
crtschin merged 4 commits into
haskell:masterfrom
crtschin:crtschin/bench-rule-key-histogram

Conversation

@crtschin

Copy link
Copy Markdown
Collaborator

Closes #5052.

Makes the following changes:

  • Use table-layout to print the tables.
  • There were some discrepencies between the csv and stdout outputs.
    • Fixes avgPerRespT in stdout, which was present in the csv but omitted in stdout
    • Fixes 1stBuildT in stdout, which didn't include firstResponseDelayed which the csv did.
  • Outputs per-rule build histogram for each benchmark.
Example output of ghcide-bench tables now
+--------------------------------+------+
|              rule              | edit |
+--------------------------------+------+
| GenerateCore                   | 1    |
| GetFileContents                | 1    |
| GetHieAst                      | 1    |
| GetModSummary                  | 1    |
| GetModSummaryWithoutTimestamps | 1    |
| GetModificationTime            | 1    |
| GetParsedModule                | 1    |
| TypeCheck                      | 1    |
| TOTAL                          | 8    |
+--------------------------------+------+
+------+---------+---------+---------+-------+-------+----------+-----------+-------------+--------+------------+--------------+--------------+------------+-----------+-------------+
| name | success | samples | startup | setup | userT | delayedT | 1stBuildT | avgPerRespT | totalT | rulesBuilt | rulesChanged | rulesVisited | rulesTotal | ruleEdges | ghcRebuilds |
+------+---------+---------+---------+-------+-------+----------+-----------+-------------+--------+------------+--------------+--------------+------------+-----------+-------------+
| edit | True    | 50      | 0.26s   | 0.00s | 1.04s | 2.73s    | 0.03s     | 0.02s       | 3.78s  | 8          | 7            | 14           | 11550      | 118607    | 2           |
+------+---------+---------+---------+-------+-------+----------+-----------+-------------+--------+------------+--------------+--------------+------------+-----------+-------------+

@crtschin
crtschin force-pushed the crtschin/bench-rule-key-histogram branch from 0babaa8 to e95449f Compare August 26, 2026 17:28
@crtschin
crtschin marked this pull request as ready for review August 26, 2026 19:18
@crtschin
crtschin requested a review from soulomoon August 26, 2026 19:18

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but only sanity checked the PR

@soulomoon soulomoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crtschin
crtschin force-pushed the crtschin/bench-rule-key-histogram branch from e95449f to d1a4116 Compare August 27, 2026 16:23
@crtschin
crtschin enabled auto-merge (squash) August 27, 2026 16:24
@crtschin
crtschin merged commit d3464b6 into haskell:master Aug 27, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output the number of times rules were built in ghcide-bench

3 participants