Add notification - #64
Open
duynguyenhoang wants to merge 3 commits into
Open
Conversation
haskellcamargo
approved these changes
Aug 14, 2018
duynguyenhoang
force-pushed
the
feature/add_notification
branch
3 times, most recently
from
August 15, 2018 10:12
a95dbbb to
36329a8
Compare
duynguyenhoang
force-pushed
the
feature/add_notification
branch
from
August 16, 2018 03:25
36329a8 to
7f50f96
Compare
Collaborator
Author
|
I need to test it some more cases this weekend. |
duynguyenhoang
force-pushed
the
feature/add_notification
branch
from
August 28, 2018 13:19
7f50f96 to
249848c
Compare
Contributor
|
How's this coming along? |
duynguyenhoang
force-pushed
the
feature/add_notification
branch
2 times, most recently
from
September 12, 2018 04:28
9fd072b to
9508a8b
Compare
duynguyenhoang
force-pushed
the
feature/add_notification
branch
from
September 12, 2018 04:30
9508a8b to
ab44d8f
Compare
Collaborator
Author
|
Hi @haskellcamargo please help me to review again. Hi @andrepcg good to go after get new approval. |
haskellcamargo
approved these changes
Feb 13, 2019
Owner
|
Sorry for the delay to approve! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support notification #43
Tested
Need help to test more Macos Versions and Linux distributions
Todo