chore(deps): bump solid-js from 1.8.17 to 1.9.13#111
Merged
Conversation
hasparus
approved these changes
Jul 1, 2026
hasparus
left a comment
Owner
There was a problem hiding this comment.
CI is green on all functional checks (lint, typecheck, build, Playwright e2e including visual regression all pass) despite the solid-js 1.8→1.9 bump. The only failing job step is Deploy Preview to Vercel (deploy.mjs: missing --token), which fails identically on every open Dependabot PR because secrets aren't available in dependabot-triggered pull_request runs — a pre-existing CI gap unrelated to this bump. Approving and merging.
Generated by Claude Code
Owner
|
·@·d·ependabot r·ebase Generated by Claude Code |
Bumps [solid-js](https://github.com/solidjs/solid) from 1.8.17 to 1.9.13. - [Release notes](https://github.com/solidjs/solid/releases) - [Changelog](https://github.com/solidjs/solid/blob/main/CHANGELOG.md) - [Commits](solidjs/solid@v1.8.17...v1.9.13) --- updated-dependencies: - dependency-name: solid-js dependency-version: 1.9.13 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
44e8ead to
e02d636
Compare
… Dependabot The solid-js 1.9 bump tightened JSX.BlockquoteHTMLAttributes typing, which requires HTMLQuoteElement (blockquote's real DOM interface, with its 'cite' attribute) rather than the generic HTMLElement used here. Under exactOptionalPropertyTypes this became a type error on the spread ref. Also carries the shared CI fix: Dependabot PRs run from the same repo (not a fork), so the deploy step's fork-only guard let it through even though GitHub withholds repository secrets from dependabot-actor runs, causing deploy.mjs to fail with 'missing --token'. Treat dependabot[bot] runs the same as fork PRs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
CI was failing for two separate reasons:
Pushed both fixes. Re-running CI now. Generated by Claude Code |
…t BlockquoteHTMLAttributes The previous attempt typed props as JSX.BlockquoteHTMLAttributes<HTMLQuoteElement>, but solid-js's BlockquoteHTMLAttributes hardcodes its ref type independent of the generic parameter, so the mismatch just flipped direction (now the JSX intrinsic's inferred ref didn't satisfy our declared props). Blockquote doesn't use the cite attribute, so follow the same pattern already used by the sibling Pre component (HTMLAttributes<T> matching the intrinsic element type) instead of the element-specific attributes interface. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rn/solid-js-1.9.13 # Conflicts: # package.json # pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps solid-js from 1.8.17 to 1.9.13.
Release notes
Sourced from solid-js's releases.
... (truncated)
Commits
3be495cv1.9.134649b37Update DOM expression runtimes265648bMerge remote-tracking branch 'origin/main'a22dd29Merge pull request #2696 from brenelz/fix-resource-initial-value-inference4b1919aFix createResource initial value inference3ed4753Tighten produce draft proxy invariant test75525f0Merge pull request #2690 from brenelz/fix/2668-leaked-produce-draft-proxy-inv...a7959caFix proxy invariant crash in draft productioncfde0a1Harden store prototype pollution guards43cbc98Merge pull request #2683 from thomasbuilds/prototype-fix