Skip to content

tidy: remove firebird config and polyfill cdn script#219

Merged
carylwyatt merged 1 commit into
mainfrom
213-follow-up
Jun 4, 2026
Merged

tidy: remove firebird config and polyfill cdn script#219
carylwyatt merged 1 commit into
mainfrom
213-follow-up

Conversation

@carylwyatt

@carylwyatt carylwyatt commented Jun 4, 2026

Copy link
Copy Markdown
Member

This is a follow-up PR to address some things I found while reviewing #213.

First, there's a cdn polyfill script for Array.prototype.at, which is now baseline widely-available, so I'm removing it.

Second, I'm removing the conditional for this localStorage workaround we used for local development of the firebird theme because we don't need/use it anymore.

@carylwyatt carylwyatt requested a review from moseshll June 4, 2026 15:11

@eumalin eumalin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's a merge conflict, otherwise everything is good.

@carylwyatt

carylwyatt commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

Looks good to me. There's a merge conflict, otherwise everything is good.

@eumalin Thanks! I noticed that right before you commented 😅 I knew there would be an issue since I'm changing the same file that was just merged. The force-push I just did cleared that up.

@moseshll moseshll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! APPROVE

@carylwyatt carylwyatt merged commit 570f16c into main Jun 4, 2026
3 checks passed
@carylwyatt carylwyatt deleted the 213-follow-up branch June 4, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants