tidy: remove firebird config and polyfill cdn script#219
Merged
Conversation
eumalin
approved these changes
Jun 4, 2026
eumalin
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. There's a merge conflict, otherwise everything is good.
Member
Author
@eumalin Thanks! I noticed that right before you commented 😅 I knew there would be an issue since I'm changing the same file that was just merged. The force-push I just did cleared that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to address some things I found while reviewing #213.
First, there's a cdn polyfill script for Array.prototype.at, which is now baseline widely-available, so I'm removing it.
Second, I'm removing the conditional for this localStorage workaround we used for local development of the firebird theme because we don't need/use it anymore.