Fix flaky Playwright test#222
Merged
Merged
Conversation
carylwyatt
approved these changes
Jun 10, 2026
carylwyatt
left a comment
carylwyatt
left a comment
Member
There was a problem hiding this comment.
I went to read about waitForLoadState, and the networkidle state is discouraged. I think we could possibly make a web assertion in here instead (maybe move the check for the main element inside this beforeEach?) but the waitForLoadState should be fine since these "setup" tests are so small.
Contributor
Author
Thank you for pointing this out! I opted to go with a web assertion instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sidebar is visibletest was flaking in CI tests. The Svelte app sometimes isn't mounted before the 5s assertion timeout.