ETT-1393 - small fixes for IA ingest#180
Merged
Merged
Conversation
* ImageRemediate: handle filenames with embedded '.' characters (previously confused file type detection for items with IA IDs containing '.' characters) * Log grok command line at TRACE level * Accept 1 <= DecompositionLevels <= 32 for IA material in general
Member
Author
|
FYI @moseshll. Small enough changes I don't think it needs much of a review. We already accept 1 - 32 for locally-digitized material (https://github.com/hathitrust/feed/blob/main/lib/HTFeed/PackageType/Simple.pm#L140), so I don't think there's any reason to insist on it for material coming through IA. |
moseshll
approved these changes
May 5, 2026
moseshll
left a comment
moseshll
left a comment
Contributor
There was a problem hiding this comment.
Passes inspection. APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageRemediate: handle filenames with embedded '.' characters (previously confused file type detection for items with IA IDs containing '.' characters)
Log grok command line at TRACE level
Accept 1 <= DecompositionLevels <= 32 for IA material in general