Use es modules#58
Merged
Merged
Conversation
Member
|
This looks good! Thanks for the explanation, it made it easy for me to know exactly what I was looking at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that the main js file was growing too big. It made more sense to split it into es modules with help from AI.
Split print-holdings-checker.js into three modules under src/js/print-holdings-checker/: validate.js has the type definitions and validation logic, ui.js has the card and error rendering, and index.js is the entry point that wires everything together.
In local dev WordPress serves the raw index.js as a native ES module, so I added a
type="module"case to the existingadd_type_attributefilter in functions.php (local env only). For deploy, esbuild now bundles the modules into the same dist/js/print-holdings-checker.min.js it always producedThe old print-holdings-checker.js is gone, and watch_build.js and package.json both point to the new entry point with
--bundleadded.