feat(Core/Algebra): to_additive and closure API for IsSubquotient - #1712
Merged
Conversation
hawkrobe
marked this pull request as draft
August 1, 2026 00:04
auto-merge was automatically disabled
August 1, 2026 00:04
Pull request was converted to draft
hawkrobe
marked this pull request as ready for review
August 1, 2026 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream polish for Subquotient.lean, folding two mathlib-reviewer audits and the register rulings:
@[to_additive]throughout, generating the fullAddMonoid.IsSubquotientAPI — including the must-fix name overrides on the product lemmas (bare to_additive generatedisSubquotient_sum_leftfor a lemma about the Prod type).IsSubquotient.prod(componentwise closure — what pseudovariety theory needs),.finite(finiteness descends; drops[Finite T]from the antisymmetry theorem),Submonoid.isSubquotient,Con.isSubquotient_quotient,MonoidHom.isSubquotient_mrange,@[to_additive (attr := refl)]on refl.transviasubmonoidComap_surjective_of_surjective, antisymmetry via thebijective_of_nat_card_lepair; leaf imports corrected (Congruence.Hom,Cardinal.Finite, explicitAlgebra.Group.Prod).MulEquiv.ofInjective'(primed per mathlib's reserved-name comment aboveofLeftInverse') extracted to its upstream-mirroring leafCore/Algebra/Group/Submonoid/Operations.lean;of_injectiveis now the compositional one-liner.