Skip to content

Upgrade to PS 0.15.4#40

Open
CGenie wants to merge 4 commits into
hdgarrood:masterfrom
garganscript:master
Open

Upgrade to PS 0.15.4#40
CGenie wants to merge 4 commits into
hdgarrood:masterfrom
garganscript:master

Conversation

@CGenie

@CGenie CGenie commented Sep 12, 2022

Copy link
Copy Markdown

This removes the deprecated Control.MonadZero monad.

I also used spago internally and found out unnecessary deps and some required one (control, foldable-traversable) so I added them to the bower.json file.

@hdgarrood

Copy link
Copy Markdown
Owner

Hey, thanks for the PR. It seems like the bower install step isn't working in CI, do you think you could resolve that?

@CGenie

CGenie commented Sep 20, 2022

Copy link
Copy Markdown
Author

I guess you should try again, I'm not sure how to work with bower, spago is much easier for me, I just copy deps from a working spago env into bower.json.

@CGenie

CGenie commented Sep 20, 2022

Copy link
Copy Markdown
Author

I don't understand the error about not being able to pull purescript-tuples.

https://github.com/purescript/purescript-tuples

The v7.0.0 tag is there.

@hdgarrood

Copy link
Copy Markdown
Owner

ECONFLICT means there's a conflict. One of the other dependencies must have a bound on tuples that precludes that version.

@CGenie

CGenie commented Sep 20, 2022

Copy link
Copy Markdown
Author

OK now when I run bower update I get no resolution questions, I guess this means no conflicts.

@CGenie

CGenie commented Sep 20, 2022

Copy link
Copy Markdown
Author

Now it throws some error about Test.Main missing.

@hdgarrood

Copy link
Copy Markdown
Owner

I think this might be a pulp bug - maybe try upgrading pulp?

@hdgarrood

Copy link
Copy Markdown
Owner

The pulp version is defined in package.json in case that wasn’t clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants