Skip to content

Only first match option. - #28

Open
grigory-leonenko wants to merge 2 commits into
helior:masterfrom
StartupMakers:master
Open

Only first match option.#28
grigory-leonenko wants to merge 2 commits into
helior:masterfrom
StartupMakers:master

Conversation

@grigory-leonenko

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling fe63130 on StartupMakers:master into * on helior:master*.

@helior

helior commented May 20, 2016

Copy link
Copy Markdown
Owner

Hey @grigory-leonenko, thanks for writing this feature! There was a previous discussion around this in #23 and I brought up the notion of highlighting the n-th index of matches, instead of just the first. That would definitely handle the first-match use-case, as well as the last-match, and anywhere else in-between using the same property (this.props.indexMatchOnly?)

It would be amazing if you could incorporate that abstraction in your code-change as well. Let me know! Thanks!

@DenisIzmaylov

DenisIzmaylov commented May 21, 2016

Copy link
Copy Markdown

+1! Could you merge that?

The first match is the most reasonable use case, have a look at:
https://www.google.com/
http://www.bing.com/
https://duckduckgo.com/

image

@DenisIzmaylov

DenisIzmaylov commented May 23, 2016

Copy link
Copy Markdown

@helior could you please merge it?
Also I think we can bump the version to 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants