Skip to content

Next release#22

Merged
baxyz merged 2 commits intomainfrom
next-release
Apr 25, 2026
Merged

Next release#22
baxyz merged 2 commits intomainfrom
next-release

Conversation

@baxyz
Copy link
Copy Markdown
Contributor

@baxyz baxyz commented Apr 25, 2026

Description

Please include a summary of what this PR does and why it's needed.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring
  • Test improvement

Related Issues

Closes #(issue number)

How Has This Been Tested?

Describe the tests you ran and how to reproduce them:

  • Test A
  • Test B

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests for my changes
  • All new and existing tests passed locally
  • My commits follow the conventional commit format

Screenshots (if applicable)

Add screenshots for UI changes.

Additional Context

Add any other context about the PR here.

Copilot AI review requested due to automatic review settings April 25, 2026 22:07
@baxyz baxyz merged commit 7438587 into main Apr 25, 2026
24 of 25 checks passed
@baxyz baxyz deleted the next-release branch April 25, 2026 22:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow used to publish devcontainer features and trigger a downstream website update when a tag release is pushed.

Changes:

  • Modifies the inputs passed to actions/create-github-app-token@v3 when generating the Trigganator token.
  • Adjusts JSON quoting/escaping for the repository-dispatch client-payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.TRIGGANATOR_ID }}
client-id: ${{ vars.TRIGGANATOR_ID }}
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/create-github-app-token@v3 expects the GitHub App identifier under the app-id input (paired with private-key). Using client-id here will be ignored by the action and will cause token generation (and the subsequent repository-dispatch) to fail. Switch this input back to app-id (or whichever exact input name the action documents) and keep the variable value the same.

Suggested change
client-id: ${{ vars.TRIGGANATOR_ID }}
app-id: ${{ vars.TRIGGANATOR_ID }}

Copilot uses AI. Check for mistakes.
repository: helpers4/website
event-type: devcontainer-release
client-payload: '{"version": "${{ github.ref_name }}"}'
client-payload: "{\"version\": \"${{ github.ref_name }}\"}"
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is still the default template (no summary, type of change, testing details, or linked issue). Please update it so reviewers/release tooling have the necessary context for what "Next release" changes and how it was verified.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

❌ PR Validation Failed

2/3 checks passed


📋 Pipeline Status

Job Status
🧾 Conventional Commits failing
🧪 Feature Tests passing
🐚 ShellCheck passing

🤖 Generated by @helpers4 CI • 2026-04-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants