chore: update CLI analytics to use heroku credential manager#3685
Merged
erika-wallace merged 1 commit intofeat/credential-mgr-integrationfrom Apr 30, 2026
Merged
Conversation
5f86e4c
into
feat/credential-mgr-integration
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates CLI analytics to use the credential manager for retrieving a user's authentication token.
BackboardHerokulyticsClientto useAPIClientfrom@heroku-cli/command, which handles credential resolution (bothHEROKU_API_KEYand stored credentials) through the shared credential manageruserandusingHerokuAPIKeygettersType of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
heroku logoutnpm install && npm run build./bin/run loginDEBUG=heroku:analytics ./bin/run whoami— in the debug output, confirm you seeheroku:analytics Successfully sent Herokulytics data./bin/run logoutDEBUG=heroku:analytics ./bin/run whoami— in the debug output, confirm you seeheroku:analytics Successfully sent Herokulytics dataScreenshots (if applicable)
Related Issues
GUS work item: W-20867247