Skip to content

chore: update CLI analytics to use heroku credential manager#3685

Merged
erika-wallace merged 1 commit intofeat/credential-mgr-integrationfrom
ew/update-cli-analytics
Apr 30, 2026
Merged

chore: update CLI analytics to use heroku credential manager#3685
erika-wallace merged 1 commit intofeat/credential-mgr-integrationfrom
ew/update-cli-analytics

Conversation

@erika-wallace
Copy link
Copy Markdown
Contributor

Summary

This PR updates CLI analytics to use the credential manager for retrieving a user's authentication token.

  • Updates BackboardHerokulyticsClient to use APIClient from @heroku-cli/command, which handles credential resolution (both HEROKU_API_KEY and stored credentials) through the shared credential manager
  • Removes unused user and usingHerokuAPIKey getters

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Notes:

Steps:

  1. Pull down this branch
  2. heroku logout
  3. npm install && npm run build
  4. ./bin/run login
  5. DEBUG=heroku:analytics ./bin/run whoami — in the debug output, confirm you see heroku:analytics Successfully sent Herokulytics data
  6. ./bin/run logout
  7. DEBUG=heroku:analytics ./bin/run whoami — in the debug output, confirm you see heroku:analytics Successfully sent Herokulytics data

Screenshots (if applicable)

Related Issues

GUS work item: W-20867247

Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erika-wallace erika-wallace merged commit 5f86e4c into feat/credential-mgr-integration Apr 30, 2026
17 checks passed
@erika-wallace erika-wallace deleted the ew/update-cli-analytics branch April 30, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants