Add Release published timestamp field to .proto#187
Merged
Conversation
elfenlaid
commented
May 17, 2026
|
|
||
| // Based on google.protobuf.Timestamp | ||
| // https://github.com/protocolbuffers/protobuf/blob/v3.15.8/src/google/protobuf/timestamp.proto#L136:L147 | ||
| message Timestamp { |
Contributor
Author
There was a problem hiding this comment.
The exact same type lives in the neighbour file
hex_core/proto/hex_pb_names.proto
Lines 17 to 24 in 795c08e
Yet, I've decided against sharing this type as I think it would be easier to replace it with a native protobuf Timestamp available in the third version of protobuf.
| -type '$msg'() :: 'Package'() | 'Release'() | 'RetirementStatus'() | 'SecurityAdvisory'() | 'Dependency'() | 'Timestamp'(). | ||
| -export_type(['$msg_name'/0, '$msg'/0]). | ||
|
|
||
| -if(?OTP_RELEASE >= 24). |
Contributor
Author
There was a problem hiding this comment.
Dear reviewers, please pay attention to this diff.
I'm not sure why these checks are dropped and it's possibly an error.
I believe it's related to gdb_opts from
Lines 7 to 17 in 22992eb
Erlang/OTP 27 [erts-15.2.7.4]
Member
|
Thank you! 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of hexpm/hex#1113
Specifically hexpm/hex#1113 (comment)
The idea is to replicate what
hexpmshows for package release published timestamps in its web interface https://github.com/hexpm/hexpm/blob/78e8f9665992de71b22571c7d09fb738fffdd5f3/lib/hexpm_web/templates/package/versions.html.eex#L7This
published_atfield is then going to be used to display a package release published dates inmix hex.outdatedand for package cooldown checks described in this proposal https://gist.github.com/ericmj/16488f164ca2045e12f0f79a73c45031