fix(core,producer): resolve relative data-start id-refs in render compile - #3252
Open
valeriangalliat wants to merge 1 commit into
Open
fix(core,producer): resolve relative data-start id-refs in render compile#3252valeriangalliat wants to merge 1 commit into
valeriangalliat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
data-start="intro"(andintro + 0.5) already resolves in the live player. Render compile treated it as a number, so relative starts failed in actual renders.Why
compileTimingAttrs/injectDurationswrotedata-endfromparseFloat("intro"). Extract prefersdata-endover duration, so the clip's end was unusable.parseSubCompositionsdid the sameparseFloaton the host, so nested media inherited a broken offset.How
parseNumericin the timing compiler. If start isn't numeric, leavedata-endoff so extract can resolve the id-ref.resolveReferencedStartwhen reading sub-composition host start (same helper video/audio/image extract already use).No new resolver. Regex compiler still has no DOM.
Test plan
bunx vitest run src/compiler/timingCompiler.test.tsinpackages/corebunx vitest run src/services/videoFrameExtractor.test.ts -t "still resolves relative data-start"inpackages/enginebun test src/services/htmlCompiler.test.ts -t "resolves a host data-start"inpackages/producer