fix(registry): clear flowchart selection after click-away - #3262
Open
AksharP5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Flowchart previews keep their blue selection outline after the cursor clicks away. This clears the outline at the intended deselection beat in both horizontal and vertical blocks.
Fixes #3261.
Why
The blocks create the outline during playback, but GSAP resolves the later fade target while constructing the timeline. At that point the element does not exist, so the fade tween has no target.
How
Added the hidden outline to each block's initial markup and moved its reveal onto the existing GSAP timeline. The later fade now binds to the element and works during normal playback and timeline seeking. Regenerated the Catalog pages and payloads.
Test plan
Validated with:
bun run buildbun run lint:registry-items flowchart flowchart-verticalbunx oxfmt --checkon all changed fileshyperframes checkagainst both standalone blocks at the selection and deselection states1while selected to0after click-awayBefore and after
Vertical
flowchart-vertical-comparison.mp4
Horizontal
flowchart-comparison.mp4