fix(catalog): sync tab labels with the sliding indicator - #3267
Open
AksharP5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Tabs Slide Indicator starts with the pill under "Plan," but marks "Debug" as active. This keeps the active label aligned with the indicator before, during, and after the slide.
Fixes #3266.
Why
The component permanently styled the second button white even though the indicator starts under the first button. Its inactive gray also measured 4.4:1 against the track, just below WCAG AA.
How
The first label now owns the initial active state, and both label colors animate with the indicator. The inactive gray moves from
#71717ato the nearest compliant shade,#6f6f78. The demo no longer pads its timeline with a no-op, and the generated Catalog payload is refreshed.Test plan
Validated with:
bun run buildbun run lint:registry-items tabs-slide-indicatorbunx oxfmt --checkon all changed filesnpx hyperframes check --snapshots --samples 15 --at-transitionsagainst the standalone demoThe full HyperFrames gate reports zero lint, runtime, layout, motion, or contrast findings. All 12 sampled text states pass WCAG AA.
Before and after
comparison.mp4