feat(core,studio): the character presets pitch shift unlocks - #3277
Open
vanceingalls wants to merge 1 commit into
Open
feat(core,studio): the character presets pitch shift unlocks#3277vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
Chipmunk, Giant, and Monster ship as presets on the pitchshift worklet P1 added: Chipmunk pitches up and adds sparkle, Giant pitches down with weight and a compressor to hold the extra low end together, Monster pitches down further with saturation growl and a close, tight reverb. Every param verified against the live effect registry rather than sketched — the compressor/reverb/saturate/shelf keys all match exactly. Each gets its own title treatment (font, size, tracking, hue) so the FX rack's per-preset styling coverage and hue-distance/background-uniqueness tests extend cleanly to the three new entries, and complaint-line copy in the non-voice vocabulary the audit test enforces (no speech words — "Giant" over CapCut's "Deep Voice", as the design doc records). Updates plans/audio-fx-presets.md's two limits paragraphs to record that pitch shift landed and this half of the character list now ships; Robot and Alien stay out of scope (ring modulation, still unbuilt). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pitchshiftworklet effect P1 added — pure data + copy, no new plumbing.audioFx.ts) rather than trusted from the step doc's sketch —pitchshift/saturate/reverb/compressor/shelf keys all matched exactly.giant, not a speech word like CapCut's "Deep Voice" (per the design doc's own near-miss).plans/audio-fx-presets.md's two limits paragraphs to record that pitch shift landed and note Robot/Alien are still out (ring modulation, unbuilt).Stack
Depends on and stacks on:
Should merge after all three.
Test plan
bun run buildcleanpackages/corefull suite: 2344/2344 passpackages/core/src/audioFxCopy.test.ts(vocabulary audit): 28/28 passpackages/studiopropertyPanelFxSection.test.tsx+propertyPanelFxPresetStyle.test.ts: 108/108 pass🤖 Generated with Claude Code