1. Two Sum#11
Open
hiro111208 wants to merge 1 commit into
Open
Conversation
rimokem
reviewed
Apr 21, 2026
| num_to_index = dict() | ||
| for i, num in enumerate(nums): | ||
| difference = target - num | ||
| if difference in num_to_index.keys(): |
There was a problem hiding this comment.
ここは、
if difference is num_to_index:でも同じ挙動になるので、そちらのほうが良いかもしれません。
There was a problem hiding this comment.
恐らく正しくは、
if difference in num_to_index:
ですね
| for i, num in enumerate(nums): | ||
| difference = target - num | ||
| if difference in num_to_index.keys(): | ||
| return [i, num_to_index[difference]] |
There was a problem hiding this comment.
[num_to_index[difference], i]として、昇順で返した方が自然だと個人的に思います。
Manato110
reviewed
Apr 21, 2026
| class Solution: | ||
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
| num_to_index = dict() | ||
| for i, num in enumerate(nums): |
There was a problem hiding this comment.
iはidxやindexの方が、今回行いたいことの意図がより読み手に明示的に伝わるかと思います。
lightbanana
reviewed
Apr 22, 2026
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
| num_to_index = dict() | ||
| for i, num in enumerate(nums): | ||
| difference = target - num |
There was a problem hiding this comment.
complement という変数名を使っている方も見かけました。趣味の範囲だと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem: 1. Two Sum
Next problem: 349. Intersection of Two Arrays