929. Unique Email Addresses#13
Open
hiro111208 wants to merge 1 commit into
Open
Conversation
nodchip
reviewed
Apr 25, 2026
| res = set() | ||
| for email in emails: | ||
| local_name, domain_name = email.split("@") | ||
| cleansed_local_name = local_name.replace(".", "").split("+")[0] |
There was a problem hiding this comment.
複数の処理が 1 行に押し込められており、やや見にくいように感じました。 2 行に分けるとよいと思います。
cleansed_local_name = local_name.replace(".", "")
cleansed_local_name = cleansed_local_name.split("+")[0]| res = set() | ||
| for email in emails: | ||
| local_name, domain_name = email.split("@") | ||
| cleansed_local_name = local_name.replace(".", "").split("+")[0] |
There was a problem hiding this comment.
比較のために正規化をすることを canonicalize と呼びます。 canonicalized_local_name はいかがでしょうか？
Owner
Author
There was a problem hiding this comment.
ご指摘いただきありがとうございます。以後使わせていただきます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem: 929. Unique Email Addresses
Next problem: 387. First Unique Character in a String